perf: Do not apply usage limit tracking on dedicated servers #2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
force-pushed
the
rate_limit_dedicated
branch
2 times, most recently
from
97c1710 to
703c6c5
Compare
It's extra overhead. It doesn't do anything right now as it is kept very high to avoid ever hitting that limit on dedicated servers.
ankush
force-pushed
the
rate_limit_dedicated
branch
from
703c6c5 to
6f2a3b7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2405 +/- ##
=======================================
Coverage 38.45% 38.46%
=======================================
Files 377 377
Lines 29403 29408 +5
=======================================
+ Hits 11307 11311 +4
- Misses 18096 18097 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's extra overhead. It doesn't do anything right now as it is kept
very high to avoid ever hitting that limit on dedicated servers.
closes frappe/caffeine#48